DA5-22: Distribution and validation of draft transactions #1413
Conversation
…idation-of-draft-transactions # Conflicts: # gradle.properties # ledger/ledger-utxo/scans/corda-ledger-utxo-5.2.0.yaml
|
Jenkins build for PR 1413 build 14 Build Successful: |
|
Scanning for breaking API changes introduced by this PR Scan Succeeded |
|
Non-blocking downstream job failed for corda-non-functional-test https://ci02.dev.r3.com/job/Corda5/job/corda-api-compatibility/job/PR-1413/6/ has failed for PR 1413 build 6 Please investigate if your changes may have broken compilation on https://github.com/corda/corda-non-functional-test |
|
Non-blocking downstream job failed for corda-e2e-test https://ci02.dev.r3.com/job/Corda5/job/corda-api-compatibility/job/PR-1413/6/ has failed for PR 1413 build 6 Please investigate if your changes may have broken compilation on https://github.com/corda/corda-e2e-tests |
ledger/ledger-utxo/src/main/java/net/corda/v5/ledger/utxo/UtxoLedgerService.java
Outdated
Show resolved
Hide resolved
ledger/ledger-utxo/src/main/java/net/corda/v5/ledger/utxo/UtxoLedgerService.java
Outdated
Show resolved
Hide resolved
ledger/ledger-utxo/src/main/java/net/corda/v5/ledger/utxo/UtxoLedgerService.java
Outdated
Show resolved
Hide resolved
| * | ||
| * @param sessions The counterparties who receive the transaction. | ||
| * @param signedTransaction The {@link UtxoSignedTransaction} to send. | ||
| * @throws CordaRuntimeException If transaction verification fails on the receiving sessions. |
There was a problem hiding this comment.
I do not think this applies to this case.
There was a problem hiding this comment.
Isn't this referring to this part of the flow?
val sendingTransactionResult = it.receive(Payload::class.java) if (sendingTransactionResult is Payload.Failure) { throw CordaRuntimeException( sendingTransactionResult.message ) }
There was a problem hiding this comment.
Yes. That propagates back the exceptions to the receiver side.
But Transaction verification cannot fail since it does not happen in the receive.
ledger/ledger-utxo/src/main/java/net/corda/v5/ledger/utxo/UtxoLedgerService.java
Outdated
Show resolved
Hide resolved
ledger/ledger-utxo/src/main/java/net/corda/v5/ledger/utxo/UtxoLedgerService.java
Outdated
Show resolved
Hide resolved
gradle.properties
Outdated
| @@ -5,7 +5,7 @@ cordaProductVersion = 5.2.0 | |||
| # NOTE: update this each time this module contains a breaking change | |||
| ## NOTE: currently this is a top level revision, so all API versions will line up, but this could be moved to | |||
| ## a per module property in which case module versions can change independently. | |||
| cordaApiRevision = 17 | |||
| cordaApiRevision = 17-julia2 | |||
There was a problem hiding this comment.
You'll need to rebase and bump the version number.
The suffix will need to be removed as well before merging.
…idation-of-draft-transactions # Conflicts: # gradle.properties
…idation-of-draft-transactions
…alidation-of-draft-transactions' into juliaf/DA5-22-Distribution-and-Validation-of-draft-transactions
…idation-of-draft-transactions
…idation-of-draft-transactions
…idation-of-draft-transactions
|
This PR is stale because it has been open 7 days with no activity. Remove the |
…idation-of-draft-transactions
…idation-of-draft-transactions
|
julia-filipczak
deleted the
juliaf/DA5-22-Distribution-and-Validation-of-draft-transactions
branch
Adding draft transaction send/receive UTXO ledger functionality
Runtime-os pr: corda/corda-runtime-os#5295
https://r3-cev.atlassian.net/browse/DI-4